Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update message used when blocking unsupported viewers. #89

Merged
merged 3 commits into from
Aug 25, 2024

Conversation

mdickson
Copy link
Collaborator

Updates error message returned when blocking a login/HG transfer due to an unsupported viewer

Change viewer banned message to a more explanatory message.
@mdickson mdickson requested review from a team and zaher and removed request for a team August 25, 2024 18:07
@mdickson mdickson self-assigned this Aug 25, 2024
@mdickson
Copy link
Collaborator Author

Merging this. I could have reviewed it but ended up putting in the PR.

@mdickson mdickson merged commit 8b2a567 into develop Aug 25, 2024
4 checks passed
@mdickson mdickson deleted the feature/fix-viewermsg branch August 25, 2024 18:08
@Christine-Nyn
Copy link

Christine-Nyn commented Aug 27, 2024 via email

@renevega
Copy link

Would "Your viewer version" rather than "Your viewer" perhaps make it clearer what is intended by the warning?

________________________________________ From: Mike Dickson @.> Sent: 25 August 2024 19:08 To: OpenSim-NGC/OpenSim-Sasquatch Cc: Christine-Nyn; Review requested Subject: Re: [OpenSim-NGC/OpenSim-Sasquatch] Update message used when blocking unsupported viewers. (PR #89) Merged #89<#89> into develop. — Reply to this email directly, view it on GitHub<#89 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AUST5O7JN3SOTQ4B2TOJGIDZTIMS5AVCNFSM6AAAAABNB42JGSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGAYDIOJWGU2DCOI. You are receiving this because your review was requested.Message ID: @.>

It will be obvious because the pop-up message would look like this example:
Access Denied - Your viewer Firestorm-Releasex64 6.3.9 is not allowed [something like that]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants